Fix Qiskit interop with v1.3 #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qiskit v1.3 changed the behavior of `num_qubits` on the `Target` class in way that broke our `QirTarget` usage, since we expect to default to `None` but the new logic ignores the `num_qubits` parameter to `__init__` and always defaults to zero qubits, failing later calls to transpilation. By shadowing the parent class property in `QirTarget` we can continue returning `None` and trigger the right behavior in transpilation while preserving a setter for use with v1.2. Fixes #2047
minestarks
reviewed
Dec 3, 2024
minestarks
reviewed
Dec 3, 2024
minestarks
approved these changes
Dec 3, 2024
orpuente-MS
reviewed
Dec 4, 2024
orpuente-MS
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qiskit v1.3 changed the behavior of
num_qubitson theTargetclass in way that broke ourQirTargetusage, since we expect to default toNonebut the new logic ignores thenum_qubitsparameter to__init__and always defaults to zero qubits, failing later calls to transpilation. By shadowing the parent class property inQirTargetwe can continue returningNoneand trigger the right behavior in transpilation while preserving a setter for use with v1.2.Note: I tested locally with both v1.2.4 and v1.3.0 integration tests to confirm the behavior is as expected.
Fixes #2047