No longer throw when attempting to hash (#2007)

Co-authored-by: Aleksey <[email protected]>
microsoft · Jan 4, 2021 · 9947037 · 9947037
1 parent 75785cb
commit 9947037
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 33 deletions.
diff --git a/windows/CodePush/CodePushNativeModule.cpp b/windows/CodePush/CodePushNativeModule.cpp
@@ -485,31 +485,10 @@ namespace Microsoft::CodePush::ReactNative
         auto configuration{ CodePushConfig::Current().GetConfiguration() };
         if (isRunningBinaryVersion)
         {
-            hstring binaryHash;
-            try
-            {
-                auto errorMessage{ L"Error: Package hashing is currently unimplemented. Binary hash was not obtained." };
-                auto error{ hresult_error(E_NOTIMPL, errorMessage) };
-                CodePushUtils::Log(error);
-                throw error;
-            }
-            catch(...)
-            {
-                CodePushUtils::Log(L"Error obtaining hash for binary contents.");
-                promise.Resolve(configuration);
-                co_return;
-            }
-
-            if (binaryHash.empty())
-            {
-                // The hash was not generated either due to a previous unknown error or the fact that
-                // the React Native assets were not bundled in the binary (e.g. during release)
-                // builds.
-                promise.Resolve(configuration);
-                co_return;
-            }
-
-            configuration.Insert(PackageHashKey, JsonValue::CreateStringValue(binaryHash));
+            auto errorMessage{ L"Error: Package hashing is currently unimplemented. Binary hash was not obtained." };
+            auto error{ hresult_error(E_NOTIMPL, errorMessage) };
+            CodePushUtils::Log(error);
+            CodePushUtils::Log(L"Error obtaining hash for binary contents.");
             promise.Resolve(configuration);
             co_return;
         }

diff --git a/windows/CodePush/CodePushPackage.cpp b/windows/CodePush/CodePushPackage.cpp
@@ -172,14 +172,9 @@ namespace Microsoft::CodePush::ReactNative
 
                 if (needToVerifyHash)
                 {
-                    try
-                    {
-                        auto errorMessage{ L"Error: package content verification is not currently supported." };
-                        hresult_error error{ E_NOTIMPL, errorMessage };
-                        CodePushUtils::Log(error);
-                        throw error;
-                    }
-                    catch (...) {}
+                    auto errorMessage{ L"Error: package content verification is not currently supported." };
+                    hresult_error error{ E_NOTIMPL, errorMessage };
+                    CodePushUtils::Log(error);
                 }
             }
         }