Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jcenter #2215

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Remove jcenter #2215

merged 4 commits into from
Nov 9, 2023

Conversation

owjsub
Copy link
Contributor

@owjsub owjsub commented Jan 31, 2022

"Based on the current timeline, builds that use JCenter will be able to resolve dependencies until February 1, 2022 without changes. After that date, there are no guarantees that you will be able to build your software if you continue to use JCenter." --https://blog.gradle.org/jcenter-shutdown

#2213

"Based on the current timeline, builds that use JCenter will be able to resolve dependencies until February 1, 2022 without changes. After that date, there are no guarantees that you will be able to build your software if you continue to use JCenter." --https://blog.gradle.org/jcenter-shutdown

microsoft#2213
@BogdanRad
Copy link

Can anyone merge this pr?

@andresesfm
Copy link
Contributor

This ticket should be closed after the PR ^^ was merged

@je7ov
Copy link

je7ov commented May 12, 2022

Anyone know when this will be merged in?

@pedpess
Copy link

pedpess commented May 13, 2022

@je7ov as a workaround you can use patch-package to patch the fix yourself while this PR is not yet merged.

Here's the diff

 buildscript {
     repositories {
-        jcenter()
+        google()
+        mavenCentral()
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:1.3.0'
@@ -15,6 +16,6 @@ buildscript {
 allprojects {
     repositories {
         mavenLocal()
-        jcenter()
+        mavenCentral()
     }
 }

@pedpess
Copy link

pedpess commented Sep 21, 2022

Change landed in 7.0.5, so I think this issue can be closed? @gabrielluka @BogdanRad

v7.0.4...v7.0.5

@huynhtastic
Copy link

Is there a timeline for adding this in? We'd really like to remove any dependencies on jcenter from our app.

Copy link

@huynhtastic huynhtastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is patched in our version of react-native-code-push and works fine

@velimir-jankovic velimir-jankovic requested a review from a team as a code owner November 8, 2023 12:35
@velimir-jankovic velimir-jankovic merged commit 64bcdba into microsoft:master Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants