-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jcenter #2215
Remove jcenter #2215
Conversation
"Based on the current timeline, builds that use JCenter will be able to resolve dependencies until February 1, 2022 without changes. After that date, there are no guarantees that you will be able to build your software if you continue to use JCenter." --https://blog.gradle.org/jcenter-shutdown microsoft#2213
Can anyone merge this pr? |
This ticket should be closed after the PR ^^ was merged |
Anyone know when this will be merged in? |
@je7ov as a workaround you can use patch-package to patch the fix yourself while this PR is not yet merged. Here's the diff buildscript {
repositories {
- jcenter()
+ google()
+ mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:1.3.0'
@@ -15,6 +16,6 @@ buildscript {
allprojects {
repositories {
mavenLocal()
- jcenter()
+ mavenCentral()
}
} |
Change landed in 7.0.5, so I think this issue can be closed? @gabrielluka @BogdanRad |
Please merge this. https://github.com/microsoft/react-native-code-push/blob/master/android/build.gradle#L5 https://github.com/microsoft/react-native-code-push/blob/master/android/build.gradle#L18 |
Is there a timeline for adding this in? We'd really like to remove any dependencies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is patched in our version of react-native-code-push and works fine
"Based on the current timeline, builds that use JCenter will be able to resolve dependencies until February 1, 2022 without changes. After that date, there are no guarantees that you will be able to build your software if you continue to use JCenter." --https://blog.gradle.org/jcenter-shutdown
#2213