test: initial e2e framework #247
Annotations
8 errors and 2 warnings
golangci-lint:
test/e2e/framework/prometheus/prometheus.go#L24
paramTypeCombine: func(promAddress string, metricName string, validMetric map[string]string) error could be replaced with func(promAddress, metricName string, validMetric map[string]string) error (gocritic)
|
golangci-lint:
test/e2e/framework/azure/create-cluster-with-npm.go#L52
appendCombine: can combine chain of 2 appends into one (gocritic)
|
golangci-lint:
test/e2e/framework/generic/load-tag.go#L36
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"tag is not set from flag nor env %s\", s.TagEnv)" (goerr113)
|
golangci-lint:
test/e2e/framework/azure/create-cluster-with-npm.go#L129
mnd: Magic number: 30, in <argument> detected (gomnd)
|
golangci-lint:
test/e2e/framework/azure/create-cluster-with-npm.go#L119
mnd: Magic number: 5, in <assign> detected (gomnd)
|
golangci-lint:
test/e2e/framework/azure/create-cluster-with-npm.go#L138
error returned from external package is unwrapped: sig: func (*github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime.Poller[github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v4.ManagedClustersClientCreateOrUpdateResponse]).PollUntilDone(ctx context.Context, options *github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime.PollUntilDoneOptions) (res github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v4.ManagedClustersClientCreateOrUpdateResponse, err error) (wrapcheck)
|
golangci-lint:
test/retry/retry.go#L35
error returned from interface method should be wrapped: sig: func (context.Context).Err() error (wrapcheck)
|
golangci-lint
issues found
|
golangci-lint:
test/e2e/framework/generic/load-tag.go#L35
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
Run actions/setup-go@v5
Restore cache failed: Dependencies file is not found in /home/runner/work/retina/retina. Supported file pattern: go.sum
|
Loading