Fix #237: Use Prometheus type Counter instead of Gauge for forward mo…

…dule's packet and byte counters
microsoft · Apr 8, 2024 · 00487a0 · 00487a0
1 parent ef779b6
commit 00487a0
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -30,12 +30,12 @@ func InitializeMetrics() {
 		dropBytesTotalDescription,
 		utils.Reason,
 		utils.Direction)
-	ForwardCounter = exporter.CreatePrometheusGaugeVecForMetric(
+	ForwardCounter = exporter.CreatePrometheusCounterVecForMetric(
 		exporter.DefaultRegistry,
 		utils.ForwardCountTotalName,
 		forwardCountTotalDescription,
 		utils.Direction)
-	ForwardBytesCounter = exporter.CreatePrometheusGaugeVecForMetric(
+	ForwardBytesCounter = exporter.CreatePrometheusCounterVecForMetric(
 		exporter.DefaultRegistry,
 		utils.ForwardBytesTotalName,
 		forwardBytesTotalDescription,

diff --git a/pkg/metrics/types.go b/pkg/metrics/types.go
@@ -53,8 +53,8 @@ var (
 	// Common counters across os distributions
 	DropCounter         IGaugeVec
 	DropBytesCounter    IGaugeVec
-	ForwardCounter      IGaugeVec
-	ForwardBytesCounter IGaugeVec
+	ForwardCounter      ICounterVec
+	ForwardBytesCounter ICounterVec
 
 	WindowsCounter IGaugeVec
 

diff --git a/pkg/module/metrics/forward.go b/pkg/module/metrics/forward.go
@@ -27,7 +27,7 @@ const (
 
 type ForwardMetrics struct {
 	baseMetricObject
-	forwardMetric metricsinit.IGaugeVec
+	forwardMetric metricsinit.ICounterVec
 	// bytesMetric metricsinit.IGaugeVec
 	metricName string
 }
@@ -47,13 +47,13 @@ func NewForwardCountMetrics(ctxOptions *api.MetricsContextOptions, fl *log.ZapLo
 func (f *ForwardMetrics) Init(metricName string) {
 	switch metricName {
 	case utils.ForwardCountTotalName:
-		f.forwardMetric = exporter.CreatePrometheusGaugeVecForMetric(
+		f.forwardMetric = exporter.CreatePrometheusCounterVecForMetric(
 			exporter.AdvancedRegistry,
 			TotalCountName,
 			TotalCountDesc,
 			f.getLabels()...)
 	case utils.ForwardBytesTotalName:
-		f.forwardMetric = exporter.CreatePrometheusGaugeVecForMetric(
+		f.forwardMetric = exporter.CreatePrometheusCounterVecForMetric(
 			exporter.AdvancedRegistry,
 			TotalBytesName,
 			TotalBytesDesc,

diff --git a/pkg/module/metrics/forward_test.go b/pkg/module/metrics/forward_test.go
@@ -290,7 +290,7 @@ func TestNewForward(t *testing.T) {
 				assert.NotNil(t, f, "forward metrics should not be nil Test Name: %s", tc.name)
 			}
 
-			forwardMock := metricsinit.NewMockIGaugeVec(ctrl) //nolint:typecheck
+			forwardMock := metricsinit.NewMockICounterVec(ctrl) //nolint:typecheck
 
 			f.forwardMetric = forwardMock