Skip to content

Commit

Permalink
fix: Turn on --output flag on Docker build for test actions
Browse files Browse the repository at this point in the history
Signed-off-by: Yerlan Baiturinov <[email protected]>
  • Loading branch information
byte-msft committed Jan 17, 2025
1 parent 0fb0297 commit 280a6cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,8 @@ jobs:
run: |
make test-image IMAGE_NAMESPACE=${{ github.repository }} PLATFORM=linux/amd64
- name: Generate coverage
run: |
pwd && ls -la
make coverage
- name: Upload Artifacts
uses: actions/upload-artifact@v4
with:
name: coverage-files
path: ./coverage*
path: ./output/coverage*
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ container-docker: buildx # util target to build container images using docker bu
image_metadata_filename="image-metadata-$$image_name-$(TAG).json"; \
touch $$image_metadata_filename; \
echo "Building $$image_name for $$os/$$arch "; \
mkdir -p $(OUTPUT_DIR); \
docker buildx build \
--platform $(PLATFORM) \
--metadata-file=$$image_metadata_filename \
Expand All @@ -253,6 +254,7 @@ container-docker: buildx # util target to build container images using docker bu
--build-arg VERSION=$(VERSION) $(EXTRA_BUILD_ARGS) \
--target=$(TARGET) \
-t $(IMAGE_REGISTRY)/$(IMAGE):$(TAG) \
--output type=local,dest=$(OUTPUT_DIR) \
$(BUILDX_ACTION) \
$(CONTEXT_DIR)

Expand Down

0 comments on commit 280a6cb

Please sign in to comment.