Skip to content

Commit

Permalink
fix(e2e): add an extra nslookup when testing for advanced DNS metrics (
Browse files Browse the repository at this point in the history
…#438)

# Description
Ref: #415. Added for Basic DNS
metrics but missed for Adv DNS metrics
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
  • Loading branch information
nddq authored Jun 5, 2024
1 parent 2824780 commit 4712ab7
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions test/e2e/scenarios/dns/scenarios.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func ValidateBasicDNSMetrics(scenarioName string, req *RequestValidationParams,
Duration: sleepDelay,
},
},
// Ref: https://github.com/microsoft/retina/issues/415
{
Step: &kubernetes.ExecInPod{
PodName: podName,
Expand Down Expand Up @@ -168,6 +169,23 @@ func ValidateAdvancedDNSMetrics(scenarioName string, req *RequestValidationParam
Duration: sleepDelay,
},
},
// Ref: https://github.com/microsoft/retina/issues/415
{
Step: &kubernetes.ExecInPod{
PodName: podName,
PodNamespace: "kube-system",
Command: req.Command,
},
Opts: &types.StepOptions{
ExpectError: req.ExpectError,
SkipSavingParamatersToJob: true,
},
},
{
Step: &types.Sleep{
Duration: sleepDelay,
},
},
{
Step: &kubernetes.PortForward{
Namespace: "kube-system",
Expand Down

0 comments on commit 4712ab7

Please sign in to comment.