test: add DNS basic and advance metrics e2e (#353)

# Description Adding DNS basic and advance metrics e2e tests ## Related Issue If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request. ## Checklist - [ ] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [ ] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [ ] I have correctly attributed the author(s) of the code. - [ ] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
microsoft · May 30, 2024 · bf616ac · bf616ac
1 parent cd0df65
commit bf616ac
Show file tree

Hide file tree

Showing 28 changed files with 897 additions and 162 deletions.
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -43,4 +43,4 @@ jobs:
         shell: bash
         run: |
           set -euo pipefail
-          go test -v ./test/e2e/scenarios/retina/*.go -timeout 30m -tags=e2e -count=1  -args -image-tag=$(make version) -image-registry=${{ vars.ACR_NAME }}  -image-namespace=${{ github.repository}}
+          go test -v ./test/e2e/*.go -timeout 30m -tags=e2e -count=1  -args -image-tag=$(make version) -image-registry=${{vars.ACR_NAME}} -image-namespace=${{github.repository}}
diff --git a/.github/workflows/images.yaml b/.github/workflows/images.yaml
@@ -215,4 +215,4 @@ jobs:
         shell: bash
         run: |
           set -euo pipefail
-          go test -v ./test/e2e/scenarios/retina/*.go -timeout 30m -tags=e2e -count=1  -args -image-tag=$(make version) -image-registry=${{ vars.ACR_NAME }}  -image-namespace=${{ github.repository}}
+          go test -v ./test/e2e/*.go -timeout 30m -tags=e2e -count=1  -args -image-tag=$(make version) -image-registry=${{ vars.ACR_NAME }}  -image-namespace=${{ github.repository}}
diff --git a/deploy/manifests/controller/helm/retina/templates/daemonset.yaml b/deploy/manifests/controller/helm/retina/templates/daemonset.yaml
@@ -161,6 +161,7 @@ spec:
           ports:
           - name: retina
             containerPort: {{ .Values.retinaPort }}
+          workingDir: $env:CONTAINER_SANDBOX_MOUNT_POINT
           command:
             - powershell.exe
             - -command

diff --git a/pkg/module/metrics/dns_test.go b/pkg/module/metrics/dns_test.go
@@ -37,7 +37,7 @@ func TestGetLabels(t *testing.T) {
 		},
 		{
 			name: "local context",
-			want: append(utils.DNSLabels, "ip", "namespace", "podname", "workloadKind", "workloadName", "service", "port"),
+			want: append(utils.DNSLabels, "ip", "namespace", "podname", "workload_kind", "workload_name", "service", "port"),
 			d: &DNSMetrics{
 				baseMetricObject: baseMetricObject{
 					srcCtx: &ContextOptions{

diff --git a/pkg/module/metrics/drops_test.go b/pkg/module/metrics/drops_test.go
@@ -106,8 +106,8 @@ func TestNewDrop(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -129,8 +129,8 @@ func TestNewDrop(t *testing.T) {
 				"destination_ip",
 				"destination_namespace",
 				"destination_podname",
-				"destination_workloadKind",
-				"destination_workloadName",
+				"destination_workload_kind",
+				"destination_workload_name",
 				"destination_service",
 				"destination_port",
 			},
@@ -153,8 +153,8 @@ func TestNewDrop(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -177,8 +177,8 @@ func TestNewDrop(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -202,8 +202,8 @@ func TestNewDrop(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},
@@ -228,8 +228,8 @@ func TestNewDrop(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},
@@ -255,8 +255,8 @@ func TestNewDrop(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},

diff --git a/pkg/module/metrics/forward_test.go b/pkg/module/metrics/forward_test.go
@@ -103,8 +103,8 @@ func TestNewForward(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -125,8 +125,8 @@ func TestNewForward(t *testing.T) {
 				"destination_ip",
 				"destination_namespace",
 				"destination_podname",
-				"destination_workloadKind",
-				"destination_workloadName",
+				"destination_workload_kind",
+				"destination_workload_name",
 				"destination_service",
 				"destination_port",
 			},
@@ -148,8 +148,8 @@ func TestNewForward(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -172,8 +172,8 @@ func TestNewForward(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -195,8 +195,8 @@ func TestNewForward(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -218,8 +218,8 @@ func TestNewForward(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},
@@ -242,8 +242,8 @@ func TestNewForward(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},
@@ -267,8 +267,8 @@ func TestNewForward(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},

diff --git a/pkg/module/metrics/tcpflags_test.go b/pkg/module/metrics/tcpflags_test.go
@@ -77,8 +77,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -99,8 +99,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"destination_ip",
 				"destination_namespace",
 				"destination_podname",
-				"destination_workloadKind",
-				"destination_workloadName",
+				"destination_workload_kind",
+				"destination_workload_name",
 				"destination_service",
 				"destination_port",
 			},
@@ -122,8 +122,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -154,8 +154,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -184,8 +184,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -222,8 +222,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"source_ip",
 				"source_namespace",
 				"source_podname",
-				"source_workloadKind",
-				"source_workloadName",
+				"source_workload_kind",
+				"source_workload_name",
 				"source_service",
 				"source_port",
 			},
@@ -261,8 +261,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"destination_ip",
 				"destination_namespace",
 				"destination_podname",
-				"destination_workloadKind",
-				"destination_workloadName",
+				"destination_workload_kind",
+				"destination_workload_name",
 				"destination_service",
 				"destination_port",
 			},
@@ -299,8 +299,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"destination_ip",
 				"destination_namespace",
 				"destination_podname",
-				"destination_workloadKind",
-				"destination_workloadName",
+				"destination_workload_kind",
+				"destination_workload_name",
 				"destination_service",
 				"destination_port",
 			},
@@ -338,8 +338,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"destination_ip",
 				"destination_namespace",
 				"destination_podname",
-				"destination_workloadKind",
-				"destination_workloadName",
+				"destination_workload_kind",
+				"destination_workload_name",
 				"destination_service",
 				"destination_port",
 			},
@@ -377,8 +377,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},
@@ -416,8 +416,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},
@@ -457,8 +457,8 @@ func TestNewTCPMetrics(t *testing.T) {
 				"ip",
 				"namespace",
 				"podname",
-				"workloadKind",
-				"workloadName",
+				"workload_kind",
+				"workload_name",
 				"service",
 				"port",
 			},

diff --git a/pkg/module/metrics/types.go b/pkg/module/metrics/types.go
@@ -36,10 +36,10 @@ const (
 	portCtxOption = "port"
 
 	// workloads context option
-	workloadKindCtxOption = "workloadKind"
+	workloadKindCtxOption = "workload_kind"
 
 	// workload context option
-	workloadNameCtxOption = "workloadName"
+	workloadNameCtxOption = "workload_name"
 
 	// workload context option
 	workloadCtxOption = "workload"

diff --git a/pkg/module/metrics/types_test.go b/pkg/module/metrics/types_test.go
@@ -34,7 +34,7 @@ func TestNewCtxOps(t *testing.T) {
 			ctxType: source,
 			expected: []string{
 				"source_ip", "source_namespace", "source_podname",
-				"source_workloadKind", "source_workloadName", "source_service", "source_port",
+				"source_workload_kind", "source_workload_name", "source_service", "source_port",
 			},
 			f:            &flow.Flow{},
 			expectedVals: []string{"unknown", "unknown", "unknown", "unknown", "unknown", "unknown", "unknown"},
@@ -45,7 +45,7 @@ func TestNewCtxOps(t *testing.T) {
 			ctxType: destination,
 			expected: []string{
 				"destination_ip", "destination_namespace", "destination_podname",
-				"destination_workloadKind", "destination_workloadName", "destination_service", "destination_port",
+				"destination_workload_kind", "destination_workload_name", "destination_service", "destination_port",
 			},
 			f:            &flow.Flow{},
 			expectedVals: []string{"unknown", "unknown", "unknown", "unknown", "unknown", "unknown", "unknown"},
@@ -56,7 +56,7 @@ func TestNewCtxOps(t *testing.T) {
 			ctxType: source,
 			expected: []string{
 				"source_ip", "source_namespace", "source_podname",
-				"source_workloadKind", "source_workloadName", "source_service", "source_port",
+				"source_workload_kind", "source_workload_name", "source_service", "source_port",
 			},
 			f: &flow.Flow{
 				Source: &flow.Endpoint{
@@ -72,7 +72,7 @@ func TestNewCtxOps(t *testing.T) {
 			ctxType: destination,
 			expected: []string{
 				"destination_ip", "destination_namespace", "destination_podname",
-				"destination_workloadKind", "destination_workloadName", "destination_service", "destination_port",
+				"destination_workload_kind", "destination_workload_name", "destination_service", "destination_port",
 			},
 			f: &flow.Flow{
 				Destination: &flow.Endpoint{

diff --git a/test/e2e/common/common.go b/test/e2e/common/common.go
@@ -0,0 +1,11 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+// package common contains common functions and values that are used across multiple e2e tests.
+package common
+
+const (
+	RetinaPort int = 10093
+	// netObsRGtag is used to tag resources created by this test suite
+	NetObsRGtag = "-e2e-netobs-"
+)