Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(images): Changing external test images to internal ones #1180

Conversation

apontejaj
Copy link
Contributor

Description

The Retina OSS CG Pipelines has been generating warnings because of two images that aren't being pulled from MCR: docker.io/bloomberg/goldpinger:v3.9.0 and ghcr.io/microsoft/retina/kapinger:latest.

The two images have been replaces by internal ones.

Full description of the issue and the solution can be found in [Spike] Investigate Retina OSS Jobs (All Warnings).

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

All warnings have been built successfully and not warning has been flagged.
https://dev.azure.com/msazure/One/_build/results?buildId=111569628&view=results

image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@apontejaj apontejaj requested a review from a team as a code owner January 2, 2025 11:24
@apontejaj apontejaj requested review from agrawaliti and mereta January 2, 2025 11:24
@apontejaj apontejaj added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 29331f0 Jan 2, 2025
27 checks passed
@apontejaj apontejaj deleted the amilcara/adding-exception-for-external-images-for-ci-pipelines branch January 2, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants