Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure jq is installed and add coverage generation in GitHub Actions #1238

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

byte-msft
Copy link
Contributor

Description

This PR addresses two issues:

  1. Ensuring that jq is installed before using it in the Makefile.
  2. Adding a make coverage step in the GitHub Actions workflow to generate coverage files prior to uploading artifacts.

Related Issue

#688
ci: minor bugs in "Test Retina Image" pipeline

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Changes

  • Add a check in the Makefile to fail early if jq is not found on the system.
  • Update the GitHub Actions workflow to run make coverage before the coverage artifacts are uploaded.

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@byte-msft byte-msft self-assigned this Jan 17, 2025
@byte-msft byte-msft requested a review from a team as a code owner January 17, 2025 13:19
@byte-msft byte-msft linked an issue Jan 17, 2025 that may be closed by this pull request
Signed-off-by: Yerlan Baiturinov <[email protected]>
@byte-msft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@byte-msft byte-msft enabled auto-merge January 17, 2025 17:01
@byte-msft byte-msft added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@byte-msft byte-msft added this pull request to the merge queue Jan 17, 2025
Merged via the queue into microsoft:main with commit a3088c8 Jan 17, 2025
27 checks passed
@byte-msft byte-msft deleted the fix/issues/688 branch January 17, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: minor bugs in "Test Retina Image" pipeline
2 participants