Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes duplicated windows metrics (#92) #213

Closed
wants to merge 1 commit into from
Closed

fix: removes duplicated windows metrics (#92) #213

wants to merge 1 commit into from

Conversation

spencermckee
Copy link
Contributor

@spencermckee spencermckee commented Apr 3, 2024 •
edited
Loading

Description

Removed the windows_hns_stats because they are already counted in the forward count.

There is no reference to the windows hns stats in the prod grafana dashboards.

Related Issue

#92

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...)
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

@spencermckee spencermckee requested a review from a team as a code owner April 3, 2024 04:53
@spencermckee spencermckee changed the title fix: removes duplicated windows metrics fix: removes duplicated windows metrics (#92) Apr 3, 2024
vakalapa
vakalapa approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@vakalapa vakalapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check with @huntergregory if these are being used in our dashboards ?

@rbtr rbtr added lang/go The Go Programming Language type/fix Fixes something area/metrics priority/1 P1 labels Apr 5, 2024
@rbtr rbtr enabled auto-merge April 5, 2024 19:08
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions bot added the meta/waiting-for-author Blocked and waiting on the author label May 6, 2024
@github-actions GitHub Actions
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this May 13, 2024
auto-merge was automatically disabled May 13, 2024 00:18

Pull request was closed

@github-actions github-actions bot deleted the spencermckee/remove-dup-windows-metrics branch May 13, 2024 00:18
@spencermckee spencermckee restored the spencermckee/remove-dup-windows-metrics branch June 3, 2024 16:42
@spencermckee spencermckee reopened this Jun 3, 2024
@spencermckee spencermckee force-pushed the spencermckee/remove-dup-windows-metrics branch from 3fb04e7 to 7c96526 Compare June 3, 2024 16:44
@github-actions github-actions bot removed the meta/waiting-for-author Blocked and waiting on the author label Jun 4, 2024
@vakalapa vakalapa enabled auto-merge June 7, 2024 20:52
@github-actions GitHub Actions
Copy link

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions bot added the meta/waiting-for-author Blocked and waiting on the author label Jul 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Aug 7, 2024
auto-merge was automatically disabled August 7, 2024 00:19

Pull request was closed

@github-actions github-actions bot deleted the spencermckee/remove-dup-windows-metrics branch August 7, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nddq nddq nddq approved these changes

@vakalapa vakalapa vakalapa approved these changes

@timraymond timraymond timraymond approved these changes

Assignees
No one assigned
Labels
area/metrics lang/go The Go Programming Language meta/waiting-for-author Blocked and waiting on the author priority/1 P1 type/fix Fixes something
Projects
Retina Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spencermckee @timraymond @vakalapa @nddq @rbtr