-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): add experimental pktmon plugin for Windows #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
added
type/enhancement
New feature or request
lang/go
The Go Programming Language
area/plugins
area/windows
priority/1
P1
labels
Apr 8, 2024
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
from
April 9, 2024 21:19
4e8c242
to
dd46db6
Compare
timraymond
reviewed
Apr 10, 2024
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
3 times, most recently
from
April 10, 2024 23:42
8750299
to
a81eeab
Compare
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
4 times, most recently
from
May 7, 2024 22:24
64d69cc
to
3b19342
Compare
/azp run |
2 similar comments
/azp run |
/azp run |
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
12 times, most recently
from
May 8, 2024 18:32
5d799f6
to
a0adc22
Compare
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
from
July 9, 2024 18:36
2c6b6cd
to
dd52282
Compare
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
from
July 15, 2024 20:57
dd52282
to
e53c80a
Compare
matmerr
commented
Jul 16, 2024
matmerr
commented
Jul 16, 2024
timraymond
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, had few comments same as Tim, not leaving duplicate comments.
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
2 times, most recently
from
July 18, 2024 17:33
56fb4c2
to
cdcae4c
Compare
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
from
July 18, 2024 17:38
cdcae4c
to
da0410c
Compare
Signed-off-by: Mathew Merrick <[email protected]>
matmerr
force-pushed
the
matmerr/pktmon-experimental
branch
from
July 18, 2024 18:05
3b84ba3
to
66c8d93
Compare
anubhabMajumdar
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugins
area/windows
lang/go
The Go Programming Language
priority/1
P1
type/enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first of many commits to add Windows flow support via pktmon in the form of a Retina plugin.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
This is an experimental build, and in the current form remains half present. Omitting Windows cgo for the time being.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.