Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): add experimental pktmon plugin for Windows #235

Merged
merged 14 commits into from
Jul 23, 2024

Conversation

matmerr
Copy link
Member

@matmerr matmerr commented Apr 6, 2024

Description

This is the first of many commits to add Windows flow support via pktmon in the form of a Retina plugin.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

This is an experimental build, and in the current form remains half present. Omitting Windows cgo for the time being.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@matmerr matmerr requested a review from a team as a code owner April 6, 2024 00:36
@rbtr rbtr added type/enhancement New feature or request lang/go The Go Programming Language area/plugins area/windows priority/1 P1 labels Apr 8, 2024
@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch from 4e8c242 to dd46db6 Compare April 9, 2024 21:19
pkg/plugin/windows/pktmon/pktmon_plugin_windows.go Outdated Show resolved Hide resolved
pkg/plugin/windows/pktmon/pktmon_plugin_windows.go Outdated Show resolved Hide resolved
pkg/plugin/windows/pktmon/pktmon_plugin_windows.go Outdated Show resolved Hide resolved
pkg/plugin/windows/pktmon/types.go Outdated Show resolved Hide resolved
@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch 3 times, most recently from 8750299 to a81eeab Compare April 10, 2024 23:42
@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch 4 times, most recently from 64d69cc to 3b19342 Compare May 7, 2024 22:24
@matmerr
Copy link
Member Author

matmerr commented May 7, 2024

/azp run

2 similar comments
@matmerr
Copy link
Member Author

matmerr commented May 7, 2024

/azp run

@matmerr
Copy link
Member Author

matmerr commented May 7, 2024

/azp run

@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch 12 times, most recently from 5d799f6 to a0adc22 Compare May 8, 2024 18:32
@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch from 2c6b6cd to dd52282 Compare July 9, 2024 18:36
@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch from dd52282 to e53c80a Compare July 15, 2024 20:57
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had few comments same as Tim, not leaving duplicate comments.

@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch 2 times, most recently from 56fb4c2 to cdcae4c Compare July 18, 2024 17:33
@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch from cdcae4c to da0410c Compare July 18, 2024 17:38
@matmerr matmerr force-pushed the matmerr/pktmon-experimental branch from 3b84ba3 to 66c8d93 Compare July 18, 2024 18:05
@matmerr matmerr added this pull request to the merge queue Jul 23, 2024
Merged via the queue into microsoft:main with commit b3c673e Jul 23, 2024
22 checks passed
@matmerr matmerr deleted the matmerr/pktmon-experimental branch July 23, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins area/windows lang/go The Go Programming Language priority/1 P1 type/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants