Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add e2e test for latency metrics in advanced scenario #414

Merged
merged 3 commits into from
May 31, 2024

Conversation

nddq
Copy link
Contributor

@nddq nddq commented May 30, 2024

Description

As title

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@nddq nddq added area/metrics area/infra Test, Release, or CI Infrastructure priority/1 P1 scope/S Change is Small labels May 30, 2024
@nddq nddq self-assigned this May 30, 2024
@nddq nddq requested a review from a team as a code owner May 30, 2024 23:28
@nddq nddq requested review from timraymond and mainred May 30, 2024 23:28
@nddq nddq linked an issue May 31, 2024 that may be closed by this pull request
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just have one brief thought.

test/e2e/scenarios/latency/scenario.go Show resolved Hide resolved
@nddq nddq added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 9f455ca May 31, 2024
21 checks passed
@nddq nddq deleted the e2e/latency branch May 31, 2024 16:18
matmerr pushed a commit to matmerr/retina that referenced this pull request Jul 3, 2024
…rosoft#414)

# Description

As title

## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Test, Release, or CI Infrastructure area/metrics priority/1 P1 scope/S Change is Small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Advanced DNS metrics e2e is flaky
2 participants