-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new manifest for Retina with Hubble #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include details of Testing Done
. Confirm if all the components are deployed, even if not running:
- retina-agent
- retina-operator
- hubble-relay pod and svc
- hubble-ui pod and sec
- all cluster roles
- configmaps
- anything else in the deployment scripts
@@ -40,7 +40,7 @@ jobs: | |||
run: | | |||
set -euo pipefail | |||
export TAG=$(make version) | |||
helm package ./deploy/manifests/controller/helm/retina --version $TAG | |||
helm package ./deploy/legacy/manifests/controller/helm/retina --version $TAG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are still using legacy charts? Will we eventually merge the hubble charts with the legacy charts? What is the strategy for this
fix import replace usage of manifest to add legacy replace usage of manifest to add legacy remove unused file update legacy manifest reference fix directories update path to use single folders add new make targets update images and tag references
36be13c
to
4ab8ad0
Compare
I am currently using the "Legacy" chart of Retina here some remarks regarding it:
|
This PR will be closed in 7 days due to inactivity. |
This PR was merged with 6aef3e3 without fixing any of the outstanding issues of the old and new chart in the first place @jimassa @snguyen64 @rbtr |
This PR will be closed in 7 days due to inactivity. |
Pull request closed due to inactivity. |
Description
This PR adds the deployment files, values as well as make targets for our hubble milestone.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Testing Done.
The following pods are present on the cluster
The following services are also found
configmaps
cluster roles
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.