Skip to content

Commit

Permalink
Remove unused rule from github.config.xml (#2813)
Browse files Browse the repository at this point in the history
The rule is now checking for more than just the HelpUri. Specifically,
it requires the name of the rule to use PascalCase. This is confusing
because this is not a requirement we have in Code Scanning.

Because Code Scanning do not show the HelpUri in the UI and it is only
provided in the API for backwards compatibility, this commit removes
the rule altogether.
  • Loading branch information
marcogario authored Jun 24, 2024
1 parent ab7f7b1 commit cdc9e15
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions policies/github.config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<!-- Upgraded from Warning, because GitHub requires this. -->
<Property Key='RuleEnabled' Value='Error' />
</Properties>
<Properties Key='SARIF2012.ProvideHelpUris.Options'>
<!-- Upgraded from Note, because GitHub displays them if available. -->
<Property Key='RuleEnabled' Value='Warning' />
</Properties>
<Properties Key='SARIF2016.FileUrisShouldBeRelative.Options'>
<!-- Not necessary because SARIF2007.ExpressPathsRelativeToRepoRoot is stricter. -->
<Property Key='RuleEnabled' Value='Disabled' />
Expand Down

0 comments on commit cdc9e15

Please sign in to comment.