HdfConverter: Map Impact=0 to Kind=Not Applicable #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candrews
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
|
Can you add something like this to ReleaseHistory.md? Obviously, update this text as you see fit to reflect the work/intent. :) BUG: Improve |
Signed-off-by: Craig Andrews <[email protected]>
candrews
force-pushed
the
hdfconverter-impact-0
branch
from
2f32911
to
01d227f
Compare
Done! |
michaelcfanning
approved these changes
Jul 27, 2023
|
OK! Should automerge shortly. You need a release after this or do we have more good stuff coming? |
|
A release would be fantastic! I'm sure there's no more coming... But this is all I know of at the moment :-) |
|
I'm looking forward to the release, thank you again! |
|
In flight. |
|
@candrews https://www.nuget.org/packages/Sarif.Sdk/4.3.0. thanks for the contributions! really helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @Amndeep7 and @aaronlippold of the MITRE SAF team, which is the team that manages the Heimdall Data Format (HDF),
impactof0indicates not applicable. See: #2695 (comment)