Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HdfConverter: SARIF location improvements #2704

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Conversation

candrews
Copy link
Collaborator

GitHub Advanced Security code scanning requires
'physicalLocation.artifactLocation.uri' to have a non-empty string
value.

Signed-off-by: Craig Andrews <[email protected]>
@candrews
Copy link
Collaborator Author

@michaelcfanning could you please take a look at this when you get a chance?

@michaelcfanning
Copy link
Member

Will jump on this today or tomorrow, sorry for the delay.

@candrews
Copy link
Collaborator Author

candrews commented Aug 4, 2023

Will jump on this today or tomorrow, sorry for the delay.

Thank you again for working with me on this project! If you have any questions about this or #2705 I look forward to promptly addressing them.

@candrews
Copy link
Collaborator Author

@michaelcfanning could you please take a look?

Thank you again!

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning
Copy link
Member

Sorry for the egregious delay here, dropped the ball initially on review and then went out of town. :(

@michaelcfanning
Copy link
Member

Updated your release notes and will now merge.

@michaelcfanning michaelcfanning enabled auto-merge (squash) August 23, 2023 19:09
@michaelcfanning michaelcfanning merged commit 84d2047 into main Aug 23, 2023
7 checks passed
@michaelcfanning michaelcfanning deleted the sarif-location branch August 23, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants