New AdvSec & GHAS - Enable using config file #2775
Conversation
shaopeng-gh
requested review from
michaelcfanning,
suvamM,
scottoneil-ms,
rwoll,
yongyan-gh,
LingZhou-gh,
EasyRhinoMSFT and
cfaucon
as code owners
| { | ||
| [Serializable] | ||
| [JsonConverter(typeof(TypedPropertiesDictionaryConverter))] | ||
| public class RuleKindSet : HashSet<RuleKind> |
There was a problem hiding this comment.
this is following the same pattern as other fields we have, the ResultKind.
The commanline nuget package the options have some limitation so there is some conversions needed
| @@ -319,7 +319,7 @@ public virtual TContext InitializeGlobalContextFromOptions(TOptions options, ref | |||
| context.TargetFileSpecifiers = options.TargetFileSpecifiers?.Any() == true ? InitializeStringSet(options.TargetFileSpecifiers) : context.TargetFileSpecifiers; | |||
| context.InvocationPropertiesToLog = options.InvocationPropertiesToLog?.Any() == true ? InitializeStringSet(options.InvocationPropertiesToLog) : context.InvocationPropertiesToLog; | |||
| context.Traces = options.Trace.Any() ? InitializeStringSet(options.Trace) : context.Traces; | |||
| context.RuleKinds = options.RuleKinds; | |||
| context.RuleKinds = options.RuleKindOption != null ? options.RuleKinds : context.RuleKinds; | |||
There was a problem hiding this comment.
no we can not,
options.RuleKindOption is not the same type as options.RuleKinds
There was a problem hiding this comment.
if you see lines above
context.ResultKinds = options.Kind != null ? options.ResultKinds : context.ResultKinds;
Some tricky here, the options.Kind is not the same type as options.ResultKinds.
p.s. I think the naming before is not good for Kind for ResultKinds , it is better to name using xxxOption, or some pattern. People will not know Kind is the command line option for ResultKinds
@EasyRhinoMSFT
This is to enable using config file to change settings for New AdvSec & GHAS work.