Fix MessageResourceNames merging #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasyRhinoMSFT
requested review from
michaelcfanning,
suvamM,
shaopeng-gh,
scottoneil-ms,
rwoll,
yongyan-gh,
LingZhou-gh and
cfaucon
as code owners
|
Anyone else getting an error when you open this in CodeFlow? |
shaopeng-gh
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous architecture seemed to be sort of incompatible with the existing skimmer platform in some cases. This change sets up lists of message strings in the rule and base classes, with the Rule.MessageResourceNames property returning a merged list. It also cleans up some overlooked messiness.