Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused coyote bits #2816

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

rwoll
Copy link
Member

@rwoll rwoll commented Jul 14, 2024

This change is part of an iterative cleanup to remove unused dependencies and code. Unused dependencies directly or transitively create additional maintenance burden.

Coyote-based testing was first introduced in #2388 but became defunct in #2625. In the latter PR, CoyoteTestOutputLogger became unreferenced but was not deleted. There are not currently any references to it either.

Since the Coyote-related tests were deleted in #2625, it's my assumption that the testing was no longer considered to have good ROI. If this is not the case, an alternative to this PR would be to revive the Coyote tests deleted in #2625. However, I'd advise that this PR land and then Coyote bits selectively brought back when/if that work gets prioritized. It's been absent for ~1.5 years.

No release note has been authored since this is a test-related change/dep that should not impact customers.

@suvamM
Copy link
Collaborator

suvamM commented Jul 15, 2024

@rwoll Your analysis is correct. Coyote is a systematic testing engine for concurrency bugs. I had started to introduce its usage, but need more bandwidth to fully leverage the tool for our concurrency tests. At this point, I don't know what our concurrency testing landscape looks like. At some point in the near future, I'd like to understand our test coverage in this domain and bring back the Coyote bits.

@rwoll rwoll merged commit c403cd9 into main Jul 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants