Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRAN repo to latest, fix one test using removed CRAN packages, ignore another #113

Merged
merged 15 commits into from
Jun 27, 2024
Merged

Update CRAN repo to latest, fix one test using removed CRAN packages, ignore another #113

merged 15 commits into from
Jun 27, 2024

Conversation

seantleonard
Copy link
Contributor

@seantleonard seantleonard commented Jun 26, 2024 •
edited
Loading

Why This Change?

  • R tests failing for a few reasons:
  1. CRAN repo used (MRAN) is deprecated. Shouldn't be used.
  2. In tests -> package Assertive.Base is no longer on CRAN
  3. In tests -> package iptools is no longer on CRAN

What is this change

  1. MRAN is deprecated. Updated repo to https://cloud.r-project.org/ per https://cran.r-project.org/mirrors.html
  2. Change package to abc.data since it has a special character, a requirement of the test it is used in.
  3. Ignore test for now because no immediate solution is known. Tracked via: iptools no longer on CRAN, breaks test.sqlPackage.dependencies.R test #114

@seantleonard seantleonard changed the title Update CRAN repo to latest Update CRAN repo to latest, fix one test using removed CRAN packages, ignore another Jun 27, 2024
@seantleonard seantleonard mentioned this pull request Jun 27, 2024
Merged
aaronburtle
aaronburtle approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@aaronburtle aaronburtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this

@seantleonard seantleonard merged commit 1060aef into master Jun 27, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronburtle aaronburtle aaronburtle approved these changes

@Aniruddh25 Aniruddh25 Awaiting requested review from Aniruddh25 Aniruddh25 is a code owner

@monamaki monamaki Awaiting requested review from monamaki monamaki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seantleonard @aaronburtle