-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prettier from 3.2.5 to 3.3.0 in /requirements #2104
Bump prettier from 3.2.5 to 3.3.0 in /requirements #2104
Conversation
Bumps [prettier](https://github.com/prettier/prettier) from 3.2.5 to 3.3.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.2.5...3.3.0) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
@@ -2,6 +2,6 @@ | |||
"name": "torchgeo", | |||
"private": "true", | |||
"dependencies": { | |||
"prettier": ">=3.0.0" | |||
"prettier": ">=3.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Domejko any idea how to prevent dependabot from updating this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a look on that tomorrow and will find some solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the simple and clean solution will be to remove npm
from .github/dependabot.yml since prettier is the only npm
package in the project.
- package-ecosystem: "npm"
directory: "/requirements"
schedule:
interval: "weekly"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then we wouldn't be able to update the lock file anymore. We want to update the latest version used in CI, we just don't want to bump the minimum required version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that with dependabot the only solution is to update package-lock.json
manually since there is no option to ignore a specific file. There is also a alternative to Dependabot, it's Renovate with this dependency bot it would be possible to ignore a specific file, in our case package.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the other option would be to keep package.json
in the root of the project where most Node projects keep it. Not ideal, let me think about it.
Superseded by #2115. |
Bumps prettier from 3.2.5 to 3.3.0.
Release notes
Sourced from prettier's releases.
Changelog
Sourced from prettier's changelog.
Commits
c4ab460
Release 3.3.08a88cdc
RespecttrailingComma
in angular templates (#15926)c2e20fb
chore(deps): update babel to v7.24.6 (#16326)41f1dff
Add newline between markdown footnote definitions (#16063)da5ad84
chore(deps): update babel to v7.24.6 (#16325)f790be8
chore(deps): update dependency file-entry-cache to v9 (#16324)7250556
chore(deps): update dependency meriyah to v4.4.3 (#16323)96e057a
chore(deps): update dependency@angular/compiler
to v18 (#16322)a4ea5a2
chore(deps): update dependency eslint-plugin-regexp to v2.6.0 (#16320)229006c
chore(deps): update dependency micromatch to v4.0.7 (#16319)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)