[Not Ready] [typespec-vscode] Add codefix for triple quate indent #5458
+213
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhongl524
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
RodgeFu
reviewed
Jan 8, 2025
| const startPos = location.pos; | ||
| const endPos = location.end; | ||
| const offSet = 3; | ||
| const splitOrIndentStr = "\r\n"; |
There was a problem hiding this comment.
the name is confusing, it's not a indent, right?
RodgeFu
reviewed
Jan 10, 2025
| const splitStr = "\r\n"; | ||
|
|
||
| const lines = splitLines(location.file.text, startPos, endPos); | ||
|
|
There was a problem hiding this comment.
handle the special case first, like 0 line, 1 line.
RodgeFu
reviewed
Jan 10, 2025
| result.push(context.prependText({ ...location, pos: startPos }, splitStr + prefix)); | ||
| } | ||
|
|
||
| if (lastLine.lineText.trim() === lines[lines.length - 1].lineText.trim()) { |
RodgeFu
reviewed
Jan 10, 2025
| let indentDiff = lastLine.indent - minIndentLine.indent; | ||
| const prefix = " ".repeat(indentDiff); | ||
| // start triple-quote is not on a new line | ||
| if (firstLine.lineText.trim() !== "") { |
There was a problem hiding this comment.
you can save the check resolve instead of trim every time
RodgeFu
reviewed
Jan 10, 2025
| lines.pop(); | ||
| } | ||
|
|
||
| if (lines.length > 0 && firstLine.lineText.trim() === lines[0].lineText.trim()) { |
RodgeFu
reviewed
Jan 10, 2025
| : lastLine.indent - minIndentLine.indent; | ||
| result.push( | ||
| context.prependText({ ...location, pos: endPos }, splitStr + " ".repeat(indentDiff)), | ||
| ); |
RodgeFu
reviewed
Jan 11, 2025
| const prefix = " ".repeat(indentDiff); | ||
| // start triple-quote is not on a new line | ||
| if (firstLine.lineText.trim() !== "") { | ||
| result.push(context.prependText({ ...location, pos: startPos }, splitStr + prefix)); |
There was a problem hiding this comment.
instead of adding fix for each line, can't we just have one fix for the whole string?
RodgeFu
reviewed
Jan 11, 2025
|
|
||
| function getIndentNumbInLine(lineText: string): number { | ||
| let curStart = 0; | ||
| const curEnd = lineText.length; |
There was a problem hiding this comment.
usually end means a position, not lenght
RodgeFu
reviewed
Jan 11, 2025
| }); | ||
| } | ||
|
|
||
| function splitLines( |
There was a problem hiding this comment.
any reason not use the existing one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4609
Add codefix for
triple-quote-indentwarning ,and meanwhile add test case for it