http-specs, test case on status code range #5577
Draft
+89
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10
to
+11
| @scenarioService("/response/status-code-range") | ||
| namespace Response.StatusCodeRange; |
There was a problem hiding this comment.
Let me know if anyone has better opinion on folder/namespace.
I thought about "payload" folder, but this is not exactly payload.
| """) | ||
| @route("/error-response") | ||
| @get | ||
| op errorResponse(): 204 | ErrorInRange | DefaultError; |
There was a problem hiding this comment.
I can remove DefaultError, as this one would not affect the code in range (494-499).
Having it there serves another scenario that different status code result into different error model in client.
|
All changed packages have been documented.
|
|
You can try these changes here
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I only added case for the range in error response.
Range can also happen on success response (e.g. 200-299).