-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ignition-fuel-tools4] Add new port 🤖 #15581
[ignition-fuel-tools4] Add new port 🤖 #15581
Conversation
The hash value seems incorrect: File does not have expected hash:
|
My bad, I fixed it now in 4d9f918 . However, I marked it as WIP as I did not tested it on all the platforms supported by CI. |
Linux build is broken by the libzip pkg-config files, that will be fixed by https://github.com/microsoft/vcpkg/pull/15589/files . I had already added the same changes here, so if the CI works we can wait for https://github.com/microsoft/vcpkg/pull/15589/files to be merged and we can rebase. |
PR #15589 has been merged to master now. You might need to revert the changes about |
66b0c65
to
dfd965e
Compare
dfd965e
to
33d670c
Compare
Thanks @NancyLi1013 ! |
What does your PR fix?
Which triplets are supported/not supported?
Does your PR follow the maintainer guide?
As discussed in #7781, different major version of ignition robotics libraries (https://ignitionrobotics.org/) can be installed side by side, so each new major version is added as a new port.
In particular, ignition-fuel-tools4 is a dependency for Gazebo 11 (http://gazebosim.org/blog/gazebo11) and for Ignition Robotics Citadel (that contains Ignition Gazebo 3, see https://www.openrobotics.org/blog/2019/12/11/ignition-citadel-released).