[openssl] [aws-c-common] Fix AWS SDK for C++ build on WASM32 and Android #17348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't set compiler when compiling for iOS
JackBoosY
added
the
category:community-triplet
…sdk_ios � Conflicts: � ports/aws-sdk-cpp/portfile.cmake � versions/a-/aws-sdk-cpp.json � versions/o-/openssl.json
…aws_wasm � Conflicts: � versions/o-/openssl.json
JackBoosY
reviewed
Apr 21, 2021
JackBoosY
approved these changes
Apr 22, 2021
JackBoosY
added
info:reviewed
JackBoosY
reviewed
Apr 25, 2021
|
Depends on #17492 |
JackBoosY
added
the
depends:different-pr
…aws_wasm � Conflicts: � ports/openssl/CONTROL � versions/baseline.json � versions/o-/openssl.json
ahmedyarub
changed the title
JackBoosY
removed
depends:different-pr
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Some of these regressions are not related to your changes. |
|
Thanks @ahmedyarub :) |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
1- Use correct make command to build OpenSSL.
2- Exclude -moutline-atomics from WASM32 and Android builds of AWS C Common library.
What does your PR fix?
Fixes building OpenSSL and AWS C Common on WASM32 and Android required by AWS SDK for C++
Which triplets are supported/not supported? Have you updated the CI baseline?
WASM32
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/