[anari] Update to 0.12.0 #43188
[anari] Update to 0.12.0 #43188
Conversation
ports/anari/portfile.cmake
Outdated
| -DBUILD_EXAMPLES=OFF | ||
| -DBUILD_VIEWER=OFF | ||
| -DBUILD_CTS=OFF | ||
| -DBUILD_EXAMPLES=OFF | ||
| -DBUILD_HDANARI=OFF | ||
| -DBUILD_HELIDE_DEVICE=OFF | ||
| -DBUILD_REMOTE_DEVICE=OFF | ||
| -DBUILD_TESTING=OFF | ||
| -DBUILD_VIEWER=OFF | ||
| -DINSTALL_CODE_GEN_SCRIPTS=ON | ||
| -DINSTALL_VIEWER_LIBRARY=ON |
There was a problem hiding this comment.
Maybe it is better to keep alphabetical order, to avoid dupliation (as now for BUILD_EXAMPLES)?
ports/anari/portfile.cmake
Outdated
| if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") | ||
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/bin" | ||
| "${CURRENT_PACKAGES_DIR}/debug/bin" | ||
| file(REMOVE_RECURSE | ||
| "${CURRENT_PACKAGES_DIR}/bin" | ||
| "${CURRENT_PACKAGES_DIR}/debug/bin" | ||
| ) | ||
| endif() |
There was a problem hiding this comment.
It is not introduced by this PR, but ... explicit removal of bin is often a misguided approach to deal with tools. (Tool must also be handled for shared linkage. The right approach is vcpkg_copy_tools(... AUTO_CLEAN).)
There was a problem hiding this comment.
I removed the full clause. No tool or alike are installed there with the new version and the updated set of compile flags.
There was a problem hiding this comment.
OK, so this one is a bit more involved and not about tools.
ANARI relies on shared libraries for its target devices, so even a static build must have those.
I update the build so that:
- the main anari library can be built as static or shared.
- VCPKG_POLICY_DLLS_IN_STATIC_LIBRARY is set to enabled.
We'll later check upstream how to handle that in a more graceful ways (that is correctly honouring BUILD_SHARED_LIBRARY CMake input). @jeffamstutz for vis.
JonLiu1993
added
the
category:port-update
Nothing gets installed in there with the new set of flags.
|
@dg0yt Thanks for the fast review. I've been addressing your comments. |
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.