Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix precedence order of cmake.parallelJobs setting #3233

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

gcampbell-msft
Copy link
Collaborator

This change addresses item #3206

This fixes the precedence order of the cmake.parallelJobs setting.

@gcampbell-msft
Copy link
Collaborator Author

@snehara99 @benmcmorran ping for review.

benmcmorran
benmcmorran previously approved these changes Jul 18, 2023
Copy link
Member

@benmcmorran benmcmorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog update.

Copy link
Contributor

@snehara99 snehara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me! Do we have a note somewhere on the preference order that users can see?

@gcampbell-msft gcampbell-msft merged commit 078e2d2 into main Jul 19, 2023
4 checks passed
@gcampbell-msft gcampbell-msft deleted the dev/gcampbell/ParallelJobs branch July 19, 2023 15:33
@gcampbell-msft
Copy link
Collaborator Author

seems good to me! Do we have a note somewhere on the preference order that users can see?

Not directly from us, but from VSCode itself, there is a proper settings order: https://code.visualstudio.com/docs/getstarted/settings#_settings-precedence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake.parallelJobs ignored in workspace's .vscode/settings.json
3 participants