determine shell for .cmd, .bat, .ps1

CHANGELOG.md

@@ -5,13 +5,15 @@
 Improvements:
 
 - Update signing to support VSCode extension signing. [#4055](https://github.com/microsoft/vscode-cmake-tools/pull/4055)
+- Ensure that any uses of `proc.spawn` work, especially for .bat and .cmd files, due to VS Code updating to Node 20. [#4037](https://github.com/microsoft/vscode-cmake-tools/issues/4037)
 
 ## 1.19.51
 
 Bug Fixes:
 
 - Fix generator and preferredGenerator logic. [#4031](https://github.com/microsoft/vscode-cmake-tools/issues/4031), [#4005](https://github.com/microsoft/vscode-cmake-tools/issues/4005), [#4032](https://github.com/microsoft/vscode-cmake-tools/issues/4032)
 
+
 ## 1.19.50
 
 Bug Fixes:

src/proc.ts

@@ -95,7 +95,7 @@ export interface ExecutionResult {
 
 export interface ExecutionOptions {
     environment?: Environment;
-    shell?: boolean;
+    shell?: boolean | string;
     silent?: boolean;
     cwd?: string;
     encoding?: BufferEncoding;
@@ -113,6 +113,18 @@ export function buildCmdStr(command: string, args?: string[]): string {
     return cmdarr.map(a => /[ \n\r\f;\t]/.test(a) ? `"${a}"` : a).join(' ');
 }
 
+export function determineShell(command: string): string | boolean {
+    if (command.endsWith('.cmd') || command.endsWith('.bat')) {
+        return 'cmd';
+    }
+
+    if (command.endsWith('.ps1')) {
+        return 'powershell';
+    }
+
+    return false;
+}
+
 /**
  * Execute a command and return the result
  * @param command The binary to execute
@@ -146,6 +158,11 @@ export function execute(command: string, args?: string[], outputConsumer?: Outpu
             log.debug(localize('execution.environment', '  with environment: {0}', JSON.stringify(final_env)));
         }
     }
+
+    if (options.shell === undefined && process.platform === "win32") {
+        options.shell = determineShell(command);
+    }
+
     const spawn_opts: proc.SpawnOptions = {
         env: final_env,
         shell: !!options.shell