Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Added folder for kubernetes helm with docker compose. Include docker-… #284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amura
Copy link

@amura amura commented Apr 15, 2020

I have created this PR to include a docker-compose configuration for when running Kubernetes and Helm inside docker. This will make it easier for those who are not only using a dockerfile configuration as all the mounts are now done inside the docker-compose. I have also included a post create command that runs the existing test file so it demonstrates successful configuration at the end.

…compose.yml file for configuring docker and an updated devcontainer.json to use the yml file. Mounts all done in docker compose
@msftclas
Copy link

msftclas commented Apr 15, 2020

CLA assistant check
All CLA requirements met.

@Chuxel
Copy link
Member

Chuxel commented Apr 21, 2020

Thanks for the contribution! A couple of things that would be great if you could do:

  1. The way this repository works is that all the contents for the dev container should be in the .devcontainer folder. This appears to depend on docker-compose.yml a level up which the person using the definition may already have on disk and we wouldn't want to overwrite.
  2. Could you link to the best way to contact you from the README.md under contributor in case there are questions for you?

@Chuxel Chuxel self-requested a review April 21, 2020 00:30
@amura
Copy link
Author

amura commented May 1, 2020

@Chuxel thanks for reviewing this. I have made the updates as you suggested!

@amura amura closed this Mar 3, 2022
@amura
Copy link
Author

amura commented Mar 3, 2022

Accidental close

@amura amura reopened this Mar 3, 2022
@bamurtaugh
Copy link
Member

Thanks again for opening this and for the discussion so far.

As a heads up, our team has been actively focused on an updated plan for community contributions and this repo moving forward, which we've now outlined in this issue: #1589. This includes moving to a couple new repos for images (https://github.com/devcontainers/images) and Features (https://github.com/devcontainers/features).

We anticipate to have a similar repo and distribution process for templates/definitions. We'll keep everyone updated (likely via another issue in this repo or comment on #1589) when our new templates repo is available and the process is defined.

Please let me know if you have any questions, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants