fix: Getting tasks for Gradle < 5.0 #1619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, will review it recently. |
jdneo
reviewed
Nov 7, 2024
| @@ -63,13 +63,20 @@ public boolean canBuild(String modelName) { | |||
| } | |||
|
|
|||
| public Object buildAll(String modelName, Project project) { | |||
| int majorVersion = Integer.parseInt(project.getGradle().getGradleVersion().split("\\.")[0]); | |||
There was a problem hiding this comment.
Is the value of project.getGradle().getGradleVersion() same as GradleVersion.current()?
If not, I think we can use
GradleVersion.version(project.getGradle().getGradleVersion()) to do the comparison
There was a problem hiding this comment.
You are right, it makes more sense this way
jdneo
reviewed
Nov 10, 2024
| subModels, tasks, node, plugins, closures, scriptClasspaths); | ||
| } | ||
|
|
||
| private List<GradleTask> getGradleTasks(Project rootProject, Project project) { |
There was a problem hiding this comment.
Can we just directly fetch the tasks with this approach no matter the project's gradle version is > or < 5? Since they look very similar.
// The original code is not implemented by me so I'm not aware of the history of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1331.
DefaultGradleProjectwas introduced to the API only in Gradle 5.0, so it does not support older versions. This implementation includes both ways for retrieving tasks