Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes that will allow an array of envFile locations to be defined #1506

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

hildo
Copy link
Contributor

@hildo hildo commented Aug 22, 2024

Changes for issue #1505

@hildo
Copy link
Contributor Author

hildo commented Aug 27, 2024

Is there something I can do to help here? I don't understand why my changes would be causing these failures? It looks like it is related to this step?
image

@hildo
Copy link
Contributor Author

hildo commented Aug 28, 2024

It looks like the tool being used (vsce) needs NodeJS minimum version 20, and the build pipeline is using version 16?
image
Should Node be upgraded?

@hildo
Copy link
Contributor Author

hildo commented Aug 29, 2024

@jdneo @testforstephen I have attempted to update the CI build to use NodeJS version 20, with the hope that the build issues will be addressed. Could someone please approve the workflow so we can see if the changes were sufficient? If I understand correctly, the workflow approval is not Pull Request approval, and just running the pipeline against this feature branch.

@testforstephen
Copy link
Contributor

please also update the envFile's type definition (should be ["array", "string"]) in package.json and description in package.nls.json

"envFile": {
"type": "string",

And

"java.debugger.launch.envFile.description": "Absolute path to a file containing environment variable definitions.",

@hildo
Copy link
Contributor Author

hildo commented Sep 2, 2024

Of course. Thank you for the review. Please let me know if I have done them correctly (I am not 100% sure that my changes to package.json are correct).

@testforstephen testforstephen merged commit 53ba640 into microsoft:main Sep 2, 2024
4 checks passed
@testforstephen
Copy link
Contributor

@hildo thanks for contribution.

@hildo
Copy link
Contributor Author

hildo commented Sep 2, 2024

Thank you!

@hildo hildo deleted the envFileArraySupport branch September 2, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants