Skip to content

Commit

Permalink
Port changes from main branch to remove diagnostic feature (#11052)
Browse files Browse the repository at this point in the history
* Reduce list of reserved files for which we warn uses of potentially interfering with kernel startup (#11044)

* Reduced reserved files that interfere with kernels

* Misc

* Remove warning about overriding python files

* Restore commented files
  • Loading branch information
DonJayamanne authored Aug 4, 2022
1 parent 2b081e7 commit e0b5fb9
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 729 deletions.
3 changes: 0 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@

### Enhancements

1. Warn users when a Python file could override an existing Python package (there by interfering with the kernels. [More info](https://aka.ms/JupyterKernelStartFailureOverrideReservedName)).
This feature could be turned off via the setting `"jupyter.diagnostics.reservedPythonNames.enabled": false`.
([#7538](https://github.com/Microsoft/vscode-jupyter/issues/7538))
1. DataFrame viewer enabled on the web.
([#9665](https://github.com/Microsoft/vscode-jupyter/issues/9665))
1. The Variable Viewer now shows strings wrapped in single quotes.
Expand Down
1 change: 1 addition & 0 deletions news/2 Fixes/11040.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reduced set of file names that are treated as reserved names that could interfere with the startup of `Python Kernels`.
26 changes: 0 additions & 26 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2042,32 +2042,6 @@
"tags": [
"experimental"
]
},
"jupyter.diagnostics.reservedPythonNames.enabled": {
"type": "boolean",
"default": true,
"markdownDescription": "%jupyter.configuration.jupyter.diagnostics.reservedPythonNames.enabled.markdownDescription%",
"scope": "machine",
"tags": [
"diagnostics"
]
},
"jupyter.diagnostics.reservedPythonNames.exclude": {
"type": "array",
"default": [
"**/site-packages/**",
"**/lib/python/**",
"**/lib64/python/**"
],
"items": {
"type": "string"
},
"uniqueItems": true,
"markdownDescription": "%jupyter.configuration.jupyter.diagnostics.reservedPythonNames.exclude.markdownDescription%",
"scope": "machine",
"tags": [
"diagnostics"
]
}
}
},
Expand Down
Loading

0 comments on commit e0b5fb9

Please sign in to comment.