Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of virtual space as discussed here: #13960
Examples of this feature:
rec.webm
rec2.webm
Most of the changes fall into one of these categories:
CursorPosition.leftoverVisibleColumns
replaced withcolumnHint
, which contains the column number that we want to stay in. This makes the calculations easier, but the change needed to be propagated to a few places.Notable changes in specific files:
replaceCommand.ts
- updated to add spaces when typing beyond end of linemouseTarget.ts
- updated to generate column for mouse positions beyond end of lineviewLines.ts
- this change was necessary to allow virtual space also on last line of a filecursorWordOperations.ts
- without this change, Ctrl + Right Arrow (next word) beyond end of line goes to the end of the line instead of the next lineTesting: