Expose shell's environment - fish #238328
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7abc263.
|
Adding isTrusted field: Good progress, I'm starting to see the env.value and env.isTrusted ( tested on bash after adding isTrusted): Progress: now working with fish as well. |
anthonykim1
commented
Jan 22, 2025
| @@ -125,7 +125,7 @@ export async function activate(context: vscode.ExtensionContext) { | |||
| return; | |||
| } | |||
|
|
|||
| const commandsInPath = await getCommandsInPath(terminal.shellIntegration?.env); | |||
| const commandsInPath = await getCommandsInPath(terminal.shellIntegration?.env?.value as { [key: string]: string | undefined }); | |||
There was a problem hiding this comment.
I'm not sure if this is the best way to handle the type errors :/ (but its giving me a pass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to break #228791 down smaller so that it is easier to review.
Part of #227467 last edition
Also adding isTrusted and changing things here and there in order to support shell env for fish without nonce