refactor: Remove lazy static instances #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 19, 2024 12:33
wmmc88
requested review from
Copilot,
NateD-MSFT and
wmmc88
and removed request for
NateD-MSFT
There was a problem hiding this comment.
Copilot reviewed 15 out of 17 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- crates/wdk-sys/Cargo.toml: Evaluated as low risk
- crates/wdk-build/Cargo.toml: Evaluated as low risk
leon-xd
commented
Dec 5, 2024
leon-xd
commented
Dec 5, 2024
leon-xd
commented
Dec 5, 2024
wmmc88
changed the title
wmmc88
requested changes
Dec 6, 2024
| @@ -74,4 +74,4 @@ redundant_explicit_links = "warn" | |||
| unescaped_backticks = "warn" | |||
|
|
|||
| [package.metadata.cargo-machete] | |||
| ignored = ["lazy_static"] # lazy_static is used in code generated by build.rs | |||
There was a problem hiding this comment.
this entire line is gone -- there's no reference to lazy_static. why do we need to keep the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced lazy static instances with std::sync::LazyLock in following locations:
Replaced lazy static instances with custom FunctionTable struct in generated code in
crates/wdk-sys/build.rs