Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package rust-driver-makefile.toml with wdk-build package #36

Merged

Conversation

wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Nov 8, 2023

Allows for downstream drivers to avoid needing to use pwsh to download the makefile, since its already included in the wdk-build source.

pending merge of #87. Review only the top commit

Also blocked on bug in sagiegurari/cargo-make#1035

@wmmc88 wmmc88 force-pushed the package-rust-driver-makefile-with-wdk-build branch 2 times, most recently from 1ce86de to e2841f9 Compare November 8, 2023 19:41
@wmmc88 wmmc88 changed the title Package rust-driver-makefile.toml with wdk-build feat: package rust-driver-makefile.toml with wdk-build package Jan 24, 2024
@wmmc88 wmmc88 force-pushed the package-rust-driver-makefile-with-wdk-build branch from e2841f9 to 867347e Compare January 30, 2024 23:48
@wmmc88 wmmc88 marked this pull request as ready for review January 30, 2024 23:50
@wmmc88 wmmc88 self-assigned this Jan 30, 2024
@wmmc88 wmmc88 requested a review from a team January 30, 2024 23:51
rajeshbg
rajeshbg previously approved these changes Jan 31, 2024
@wmmc88 wmmc88 force-pushed the package-rust-driver-makefile-with-wdk-build branch from 867347e to ba85e5a Compare February 2, 2024 20:21
hamzamust
hamzamust previously approved these changes Feb 2, 2024
@wmmc88 wmmc88 enabled auto-merge February 2, 2024 20:22
rajeshbg
rajeshbg previously approved these changes Feb 3, 2024
@wmmc88 wmmc88 added this pull request to the merge queue Feb 3, 2024
@wmmc88 wmmc88 removed this pull request from the merge queue due to a manual request Feb 3, 2024
@wmmc88 wmmc88 added this pull request to the merge queue Feb 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 3, 2024
@wmmc88 wmmc88 dismissed stale reviews from rajeshbg and hamzamust via 916f9e3 February 3, 2024 01:24
@wmmc88 wmmc88 force-pushed the package-rust-driver-makefile-with-wdk-build branch from ba85e5a to 916f9e3 Compare February 3, 2024 01:24
@wmmc88 wmmc88 enabled auto-merge February 3, 2024 01:29
@wmmc88 wmmc88 added this pull request to the merge queue Feb 5, 2024
Merged via the queue into microsoft:main with commit 103ad12 Feb 5, 2024
48 checks passed
@wmmc88 wmmc88 deleted the package-rust-driver-makefile-with-wdk-build branch February 5, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants