-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify settings behavior #5062
base: master
Are you sure you want to change the base?
Clarify settings behavior #5062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They affect more than just install
. If I'm not mistaken, they also affect upgrade and import.
In fact, I would think it's nore likely a bug in DSC if they aren’t being considered when used with the WinGetPackage resource; especially becausethefe doesn’t seem to be Scope
or Locale
or InstallerType
properties on the DSC Resource (@denelon - should these be added? Should I open an issue for that?)
Thanks for the reply Kaleb. If that's the case, then I would even think of renaming the setting name, as it states |
Unfortunately I think that renaming the setting would be considered a breaking change (unless both the old name and the new name would work) |
I agree; maybe only introducing |
Then you get into weird semantics because an upgrade is just a special case of install |
In general, a WinGet Configuration shouldn't be affected by a user's Package Management settings. That's probably something we'll need to clarify. |
In that case, does the DSC Resource need to be updated to support Scope, Locale, and installer type? It seems like a gap between the DSC Resource and the WinGet Client if there isn’t a way to specificy which is the preferred scope, or preferred installer |
Yes, we have an issue open for that work as well. |
Ah, I knew I was missing something! |
When looking through the discussions, I noticed the following question asked by Tristan. After trying out some options, I thought the
ConfigureBehavior
would do the trick. Unfortunately, after trying it out, I took the conclusion from the description that onlywinget install
is affected by these settings. This pull request clarifies it a bit more.Microsoft Reviewers: Open in CodeFlow