Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootstrapping an IDE easier #117

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Nov 5, 2024

Microsoft Reviewers: Open in CodeFlow

@Trenly
Copy link
Contributor Author

Trenly commented Nov 5, 2024

@denelon

denelon
denelon previously approved these changes Nov 5, 2024
@denelon
Copy link
Contributor

denelon commented Nov 5, 2024

Hey, would you be interested in building a WinGet Configuration for folks that would ensure VSCode and the extension is installed?

I'm going to update the guidance in the future, so for now I'd put one as "./configurations/configuration.dsc.yaml"
And I'd put a copy of it under the new location in the future as well. I'm still talking with @crutkas and others about the new guidance.

We're going to suggest using the ".winget" extension for the configuration files in Git based projects. I think Clint was suggesting using the ".config" directory, but I didn't want to step on anything there by adding another "*.yaml" file. I've also seen a PR to add ".winget" as a YAML extension in VSCode.

@Trenly
Copy link
Contributor Author

Trenly commented Nov 5, 2024

Yep! I can do that

@Trenly Trenly changed the title Add Powershell to the recommended extensions Make bootstrapping an IDE easier Nov 5, 2024
@denelon
Copy link
Contributor

denelon commented Nov 5, 2024

The ID is displayed in the output of the run which is nice as well:

image

It might be worth adding ids for the extensions.

@Trenly Trenly requested a review from denelon November 5, 2024 22:55
@denelon
Copy link
Contributor

denelon commented Nov 5, 2024

It worked on my local x64 device (some of the components were already installed):
image

Next, I'll test in Windows Sandbox.

@Trenly
Copy link
Contributor Author

Trenly commented Nov 5, 2024

I could probably shorten some of the IDs too

@denelon
Copy link
Contributor

denelon commented Nov 5, 2024

It looks like it might not be installing the extensions.

Can you verify on your end if they are appearing? It might be how the Sandbox WDAGUtility account is administrator or something else might be broken on my end.

image

@Trenly
Copy link
Contributor Author

Trenly commented Nov 5, 2024

Will check

@Trenly
Copy link
Contributor Author

Trenly commented Nov 6, 2024

@denelon - It does not install the extensions for me. So, I switched over to using the Microsoft.VSCode.DSC module in this repo. . . . and they still don't install. Doesn't matter if VSCode is open or closed.

PS C:\Users\Trenly> Invoke-DscResource -Name VSCodeExtension -ModuleName Microsoft.VSCode.Dsc -Method Get -Property @{Name='redhat.vscode-yaml'}

Name               Version Exist Insiders
----               ------- ----- --------
redhat.vscode-yaml 1.15.0   True    False

PS C:\Users\Trenly> Invoke-DscResource -Name VSCodeExtension -ModuleName Microsoft.VSCode.Dsc -Method Test -Property @{Name='redhat.vscode-yaml'}

InDesiredState
--------------
          True

PS C:\Users\Trenly> Invoke-DscResource -Name VSCodeExtension -ModuleName Microsoft.VSCode.Dsc -Method Get -Property @{Name='EditorConfig.EditorConfig'}

Name                      Version Exist Insiders
----                      ------- ----- --------
EditorConfig.EditorConfig         False    False

PS C:\Users\Trenly> Invoke-DscResource -Name VSCodeExtension -ModuleName Microsoft.VSCode.Dsc -Method test -Property @{Name='EditorConfig.EditorConfig'}

InDesiredState
--------------
         False

PS C:\Users\Trenly> Invoke-DscResource -Name VSCodeExtension -ModuleName Microsoft.VSCode.Dsc -Method set -Property @{Name='EditorConfig.EditorConfig'}

RebootRequired
--------------
         False

PS C:\Users\Trenly> Invoke-DscResource -Name VSCodeExtension -ModuleName Microsoft.VSCode.Dsc -Method test -Property @{Name='EditorConfig.EditorConfig'}

InDesiredState
--------------
         False

@denelon
Copy link
Contributor

denelon commented Nov 6, 2024

OK, so it looks like we have a bug to go chase down.

@Trenly
Copy link
Contributor Author

Trenly commented Nov 6, 2024

Given that it isn't a bug with the configuration file, but a bug in the DSC Resource, should this wait to merge?

@denelon
Copy link
Contributor

denelon commented Nov 11, 2024

Do you want me to go ahead and merge it since we have a bug on the module already created? I'm fine with that since the blast radius is small right now.

@Trenly
Copy link
Contributor Author

Trenly commented Nov 11, 2024

I think that would be great @denelon

@ryfu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yaml looks good to me so lets go ahead and get this checked in. I'll look into fixing the bug for VSCode dsc.

@ryfu-msft ryfu-msft merged commit 1a27d68 into microsoft:main Nov 11, 2024
5 checks passed
@Trenly Trenly deleted the MoreSetup branch November 11, 2024 19:19
@Trenly
Copy link
Contributor Author

Trenly commented Nov 11, 2024

The yaml looks good to me so lets go ahead and get this checked in. I'll look into fixing the bug for VSCode dsc.

Already raised a PR to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants