You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the GitConfigFile resource in the GitDsc module didn't actually exist. So, I removed it and added the test for listing the available resources. I also added a basic test for the GitClone resource. I wasn't familiar enough with the other resources in the module to add tests for them, but I figured that some tests were better than none. If this PR merges, I'll raise an issue for tracking that the additional tests should be added
I think the issue is actually that Git just isn't installed, so there is no way for it to actually clone the repository.
I think this leaves 2 options -
Have the tests install Git using Microsoft.WinGet.DSC
Have some test data or test files that can be copied to the directory in place of asserting that the actual process of running git clone works
Edit: Just realized that option 2 won't work, since that also requires git to be installed 🤦
Okay, that was harder than I thought it would be, since Pester doesn't like to play nice if you don't have the scopes set juuuuuust right, but I think I got it to work
Okay, now I'm truly lost. This is the error on line 22 -
##[error] [-] Discovery in D:\a\_work\1\s\tests\GitDsc\GitDsc.Tests.ps1 failed with:
##[error] System.Management.Automation.ActionPreferenceStopException: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: The 'Assert-Git' command was found in the module 'GitDsc', but the module could not be loaded. For more information, run 'Import-Module GitDsc'.
But yet the module is imported on line 19 in the BeforeAll block ???
Edit: When the module is imported, it calls Assert-Git. That assertion fails because Git is not installed in the pipelines. The failed assertion throws, which causes Pester to not be able to bind into the container
Why do I even try. I uninstalled Git, and the tests passed for me. I tried it in a VM, and the tests passed for me. I have no clue what's going wrong. I'll revisit this later once I have a bit more time
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
GitConfigFileresource in theGitDscmodule didn't actually exist. So, I removed it and added the test for listing the available resources. I also added a basic test for theGitCloneresource. I wasn't familiar enough with the other resources in the module to add tests for them, but I figured that some tests were better than none. If this PR merges, I'll raise an issue for tracking that the additional tests should be added