-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WhatIf support for DSC v3 #89
Conversation
@ryfu-msft If you have some time, you mind checking out this PR? I changed the logic to retrieve data when starting |
Tested locally. All tests passed. Can you trigger the pipeline? |
Looks like we checked in some changes causing merge conflicts. Can you resolve them and I'll kick off a rerun. |
This comment has been minimized.
This comment has been minimized.
Should be good to go @ryfu-msft ! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @Trenly, I don't know why I had to add itsdangerouss twice to the list, but afterwards, it succeeded. FYI. |
I'm not sure what's going on with |
For Note that |
Good point and Kaleb reminded me as well to add it to the correct files. |
Thanks for the heads-up about And it's fixed in prerelease as you can see from this report@check-spelling-bot Report🔴 Please reviewSee the 📜action log or 📝 job summary for details.Unrecognized words (1)confrimation These words are not needed and should be removedToolpackageTo accept these unrecognized words as correct, you could apply this commit... in a clone of the [email protected]:check-spelling-sandbox/winget-dsc.git repository git am <<'@@@@3eac0379655cc021222446138658baab9bcfb18e--1730918238'
From 390626c4aa116fb728a7685be732bcec4c67aafa Mon Sep 17 00:00:00 2001
From: Josh Soref <[email protected]>
Date: Wed, 6 Nov 2024 18:37:17 +0000
Subject: [PATCH] [check-spelling] Update metadata
check-spelling run (push) for whatif-support
Signed-off-by: check-spelling-bot <[email protected]>
on-behalf-of: @check-spelling <[email protected]>
---
.../spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt | 1 +
.github/actions/spelling/expect/software.txt | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
create mode 100644 .github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt
diff --git a/.github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt b/.github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt
new file mode 100644
index 0000000..e8309cb
--- /dev/null
+++ b/.github/actions/spelling/expect/588ee95ffe45b0dc6a84d481385ef17a835297ee.txt
@@ -0,0 +1 @@
+confrimation
diff --git a/.github/actions/spelling/expect/software.txt b/.github/actions/spelling/expect/software.txt
index 8ed24f0..82e7f85 100644
--- a/.github/actions/spelling/expect/software.txt
+++ b/.github/actions/spelling/expect/software.txt
@@ -5,4 +5,3 @@ dotnettool
cspell
NUnit
reportgenerator
-Toolpackage
--
2.47.0
@@@@3eac0379655cc021222446138658baab9bcfb18e--1730918238 And OR To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:check-spelling-sandbox/winget-dsc.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling-sandbox/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/check-spelling-sandbox/winget-dsc/actions/runs/11709369433/attempts/7'
Pattern suggestions ✂️ (3)You could add these patterns to
Warnings (2)See the 📜action log or 📝 job summary for details.
See If the flagged items are 🤯 false positivesIf items relate to a ...
Details 🔎📂 candidate-pattern📂 no-newline-at-eof
📂 unrecognized-spelling
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
@ryfu-msft I checked the logs and I saw what went wrong. Just commited a fix that makes sure the package is always uninstall, before doing whatif to meet the satisfaction |
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
@Gijsreyn , you still have issues with spelling, you can probably avoid having to mess with that if you just did something simple like |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@ryfu-msft I went with the suggestion from Josh, but just changed it. |
I'm doing something terrible wrong Ryan. Shouldn't be writing code when I'm death tired. Sorry for the tiny commits. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Haha no need to apologize. Thank you for your contribution, this is really great. Everything looks good to me, lets get this checked in and published! |
This PR adds WhatIf support.
Note
WhatIf support is currently not implemented in DSC v3, see issue.