Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scope for jmh dependencies #10

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

ClaasJG
Copy link
Contributor

@ClaasJG ClaasJG commented Oct 17, 2023

Hi,

currently, clipper2-java leaks jmh-core and jmh-generator-annprocess when consuming it via jitpack.io.
Both dependencies are only required for the JMH benchmarks. Based on the readme of the used jmh plugin

This plugin does not generate the uber-jar as is usual with the default JMH approach. It instead just invokes the benchmark with the test classpath.

which means, that those dependencies can use the test scope.

Thanks for the port and have a nice day

-ClaasJG

@micycle1 micycle1 merged commit 706ae87 into micycle1:master Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants