New Router: CloudFormation Custom Resource #1268
Open
+888
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1260
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
willfarrell
changed the title
DavidWells
reviewed
Dec 13, 2024
Co-authored-by: David Wells <[email protected]>
Comment on lines
32
to
39
| if (typeof handler !== 'undefined') { | ||
| const response = handler(event, context, abort) | ||
| response.Status ??= 'SUCCESS' | ||
| response.RequestId ??= event.RequestId | ||
| response.LogicalResourceId ??= event.LogicalResourceId | ||
| response.StackId ??= event.StackId | ||
| return response | ||
| } |
There was a problem hiding this comment.
It would be nice if it also reported to the responseUrl, I feel like even though the abstraction is nice, it doesn't really add that much value currently as it's still the responsibility of the developer to correctly handle all errors and respond.
The auto reporting implementation is more what I was looking for honestly
| return (event, context, abort) => { | ||
| const { RequestType: requestType } = event | ||
| if (!requestType) { | ||
| return notFoundResponse({ requestType }) |
There was a problem hiding this comment.
I would for example expect that here we report to cloudformation that we have a failure, because if we don't do that cloudformation will simply wait x time until it timeouts whilst we already know that we won't be handling the request
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1260
Todo List: