chore: Small test cleanup & versions upgrade.

.github/workflows/main.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Build esm
         run: yarn build:esm
       - name: Install puppeteer and static
-        run: yarn add puppeteer@9.1.1 [email protected]
+        run: yarn add puppeteer@23.9.0 [email protected]
       - name: Launch static
         run: yarn static &
       - name: Browser Test

eslint.config.mjs

@@ -0,0 +1,45 @@
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [...compat.extends(
+    "eslint:recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+), {
+    plugins: {
+        "@typescript-eslint": typescriptEslint,
+    },
+
+    languageOptions: {
+        parser: tsParser,
+    },
+
+    rules: {
+        "@typescript-eslint/explicit-module-boundary-types": "off",
+        "@typescript-eslint/no-inferrable-types": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-non-null-assertion": "off",
+        "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/no-require-imports": "off",
+
+        "sort-imports": ["error", {
+            ignoreDeclarationSort: true,
+            ignoreMemberSort: true,
+            memberSyntaxSortOrder: ["none", "all", "single", "multiple"],
+        }],
+
+        "comma-dangle": ["error", "always-multiline"],
+    },
+}];

package.json

@@ -9,25 +9,24 @@
   "types": "dist/index.d.ts",
   "private": false,
   "devDependencies": {
-    "@istanbuljs/nyc-config-typescript": "^1.0.1",
-    "@magic-works/ttypescript-browser-like-import-transformer": "^3.0.0",
-    "@types/crypto-js": "3.1.43",
-    "@types/jsbn": "1.2.29",
-    "@types/node": "^15.0.3",
-    "@typescript-eslint/eslint-plugin": "^4.23.0",
-    "@typescript-eslint/parser": "^4.23.0",
+    "@istanbuljs/nyc-config-typescript": "^1.0.2",
+    "@magic-works/ttypescript-browser-like-import-transformer": "^4.0.0",
+    "@types/crypto-js": "4.2.2",
+    "@types/jsbn": "1.2.33",
+    "@types/node": "^20.8.4",
+    "@typescript-eslint/eslint-plugin": "^8.16.0",
+    "@typescript-eslint/parser": "^8.16.0",
     "@zoltu/typescript-transformer-append-js-extension": "^1.0.1",
-    "eslint": "^7.26.0",
-    "nyc": "^15.1.0",
+    "eslint": "^9.15.0",
+    "nyc": "^17.1.0",
     "prettier": "^2.3.0",
     "source-map-support": "^0.5.19",
     "tap-diff": "^0.1.1",
-    "tap-junit": "^4.2.0",
-    "tape": "^5.2.2",
+    "tape": "^5.9.0",
     "tape-promise": "^4.0.0",
-    "ts-node": "^9.1.1",
-    "ttypescript": "^1.5.12",
-    "typescript": "^4.2.4"
+    "ts-node": "^10.9.2",
+    "ttypescript": "^1.5.15",
+    "typescript": "^4.9.5"
   },
   "scripts": {
     "build": "yarn tsc --build tsconfig.json",

src/cross-env-crypto.ts

@@ -10,7 +10,6 @@ export let crossEnvCrypto: CompatibleCrypto;
 try {
   const webcrypto =
     (typeof window !== "undefined" && window.crypto) ||
-    // eslint-disable-next-line @typescript-eslint/no-var-requires
     require("crypto").webcrypto; // Node v15+ has webcrypto built in, lets use that if we can
 
   if (webcrypto) {
@@ -33,7 +32,7 @@ try {
     };
   } else {
     // otherwise lets use node's crypto
-    // eslint-disable-next-line @typescript-eslint/no-var-requires
+
     const nodeCrypto = require("crypto");
     const nodeCreateHashToHashFunction =
       (algorithm: AlgorithmIdentifier) => (data: ArrayBuffer) =>

test/parameters.test.ts

@@ -31,12 +31,10 @@ test("Size of N is correct", (t) => {
   // Yes, the 256 bits number is actually 257 bits number
   // https://groups.google.com/forum/#!topic/clipperz/DJFqZYHv2qk
   const expectedSizeInBytes: number[] = [33, 64, 96, 128, 192, 256];
-  const actualSizeInBytes: number[] = new Array(6).fill(0);
-  Object.keys(SRPParameters.PrimeGroup).map((key, idx) => {
-    actualSizeInBytes[idx] = bigIntToArrayBuffer(
-      SRPParameters.PrimeGroup[key].N,
-    ).byteLength;
-  });
-  actualSizeInBytes.sort((x, y) => x - y);
+  const actualSizeInBytes: number[] = Object.keys(SRPParameters.PrimeGroup)
+    .map(
+      (key) => bigIntToArrayBuffer(SRPParameters.PrimeGroup[key].N).byteLength,
+    )
+    .sort((x, y) => x - y);
   t.deepEqual(expectedSizeInBytes, actualSizeInBytes, "N sizes are correct");
 });

tsconfig.esm.json

@@ -11,7 +11,7 @@
     "noImplicitThis": true,
     "strict": true,
     "noImplicitAny": false,
-    "typeRoots": ["node_modules/@types", "types"],
+    "typeRoots": ["node_modules/@types"],
     "plugins": [{
       "transform": "@magic-works/ttypescript-browser-like-import-transformer",
       "after": true

tsconfig.json

@@ -11,7 +11,7 @@
     "noImplicitThis": true,
     "strict": true,
     "noImplicitAny": false,
-    "typeRoots": ["node_modules/@types", "types"]
+    "typeRoots": ["node_modules/@types"]
   },
   "include": ["src/**/*"]
 }