Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first epoch downloaded has incomplete data #131

Open
santi1234567 opened this issue Sep 6, 2024 · 1 comment · May be fixed by #136
Open

The first epoch downloaded has incomplete data #131

santi1234567 opened this issue Sep 6, 2024 · 1 comment · May be fixed by #136
Assignees
Labels
bug Something isn't working

Comments

@santi1234567
Copy link
Member

santi1234567 commented Sep 6, 2024

Description

The first epoch downloaded when running goteth will allways have the PrevState.EmptyStateRoot() flag on. This means that this epoch will be stored with incomplete data on the database.

Example from phase0 but applies to all forks:

func (p *Phase0Metrics) PreProcessBundle() {
if !p.baseMetrics.PrevState.EmptyStateRoot() && !p.baseMetrics.CurrentState.EmptyStateRoot() {
p.GetInclusionDelayDeltas()
p.GetMaxAttComponentDeltas()
}
}

@santi1234567 santi1234567 added the bug Something isn't working label Sep 6, 2024
@santi1234567
Copy link
Member Author

santi1234567 commented Sep 6, 2024

A possible solution (and probably easiest) is to start downloading from the epoch before the set one. This would require handling the case of epoch 0 as an exception. When running on finalized mode, this might be problematic and should be handled with special care.

Update: This won't work since it would overwrite the value from the epoch before

@santi1234567 santi1234567 self-assigned this Sep 23, 2024
@santi1234567 santi1234567 linked a pull request Sep 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant