Fix/the first epoch downloaded has incomplete data #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santi1234567
deleted the
fix/the-first-epoch-downloaded-has-incomplete-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first epoch downloaded when running goteth would allways have the
PrevState.EmptyStateRoot()flag on. This means that this epoch would be stored with incomplete data on the database.Now we wait until we have 2 epochs downloaded before the current epoch to start storing epoch and rewards data. This ensures that we have the required info and there isn't incomplete data. Goteth now always downloads two epochs before the starting point as well to not leave gaps.
Closes #131