replaced jsdom with cheerio, made a test that works #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get url in route callback
typo fix
…nd invoke matching route handlers regardless of HTTP response code Replaced headers, body and fromCache components of the 'this' injected into route handlers with the full HTTP response. This response contains the body and the fromCache aspect is available from the HTTP statusCode that is also part of the response. The body component now comes from the response rather than the body parameter passed into the request.get callback. Also, removed conditions that prevented route handlers being invoked if the status code was not 200 or 304. Fixed broken tests. Added a new test that uses assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsdom seems way too strict. cheerio is much more flexible. had to change the semantics of the spider() call on new links since I couldn't get the same _.extend() call to work on the cheerio jquery object. the way I have it now it just recycles the call to get() instead. this seems cleaner to me but there might be something I've broken...