Specify a code style via clang-format --style=webkit
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikesart I understand there is a high chance you may not like it and I obviously respect that. Feel free to play around with different styles ( I noticed there hasn't been anything to automated formatter, so let's see if anything sticks. |
|
I wind up working in a bunch of codebases, so as long as things are consistent I'm happy. If you like this one then +1 from me on applying to all the current files and committing. Thanks Motiejus. |
clang-format --style=webkit is closest to the current style. Most
notably, `calling_a_function ( "has more spaces now" )` than
`calling_a_function("would have in this change")`
Let me know what you think. The files were changed with `make lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format --style=webkit is closest to the current style. Most notably,
calling_a_function ( "has more spaces now" )thancalling_a_function("would have in this change")Let me know what you think. The files were changed with
make lint.