Skip to content

Commit

Permalink
This fixes #100
Browse files Browse the repository at this point in the history
  • Loading branch information
mikibonacci committed Oct 22, 2024
1 parent ff40d39 commit 2d09a71
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/aiidalab_qe_vibroscopy/workflows/vibroworkchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ def get_builder_from_protocol(

# MBO: I do not understand why I have to do this, but it works
builder.phonon = builder_phonon
builder.phonon.symmetry = overrides["symmetry"]
builder.phonon.symmetry = orm.Float(overrides["symmetry"])

# Adding the bands and pdos inputs.
if structure.pbc != (True, True, True):
Expand Down Expand Up @@ -732,7 +732,10 @@ def vibrate(self):
def should_run_phonopy(self):
# Final phonopy is needed for modes 1 and 3;
# namely, we compute bands, pdos and thermo.
return "phonopy_bands_dict" in self.inputs
return (
"phonopy_bands_dict" in self.inputs
and self.ctx[self.ctx.key].is_finished_ok
)

def run_phonopy(self):
"""Run three `PhonopyCalculation` to get (after the calculations of force constants) bands, pdos, thermodynamic quantities."""
Expand Down

0 comments on commit 2d09a71

Please sign in to comment.