Lazy loading euphonic #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cci/aiidalab-qe-vibroscopy into lazy_loading_compatible
missing: download of the data, proper testing, detached app.
The problem was that the default value of a tl.List(tl.Float()) is tl.Undefined. Now we explicitely reset the default value of Q0_vec, h_vec and k_vec
For now, I added it at the end of the main EuphonicBaseResultsWidget. It will only allow to download phonopy.yaml and fc.hdf5. The plots can be downloaded in the corresponding tabs. I added a method to the model which produce the downloadable files, and left the actual _download_data method in the widget. I think this is a proper design as the model manipulates data, the view can provide them. Still missing the download of single tabs, for now it does not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AndresOrtegaGuerrero , this PR is to add the euphonic lazy loaded results.
For now I think we can merge into your branch, and then proceed from there.
Missing parts are:
all these missing things can be pushed into your branch as soon as I have done them.